pgsql: Remove no-op GiST support functions in the core GiST opclasses.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove no-op GiST support functions in the core GiST opclasses.
Date: 2017-09-20 03:33:24
Message-ID: E1duVlM-0001ec-TR@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove no-op GiST support functions in the core GiST opclasses.

The preceding patch allowed us to remove useless GiST support functions.
This patch actually does that for all the no-op cases in the core GiST
code. This buys us whatever performance gain is to be had, and more
importantly exercises the preceding patch.

There remain no-op functions in the contrib GiST opclasses, but those
will take more work to remove.

Discussion: https://postgr.es/m/CAJEAwVELVx9gYscpE=Be6iJxvdW5unZ_LkcAaVNSeOwvdwtD=A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2d484f9b058035d41204f2eb8a0a8d2e8ee57b44

Modified Files
--------------
src/backend/access/gist/gistproc.c | 32 ++------------------------------
src/backend/utils/adt/network_gist.c | 12 ++----------
src/backend/utils/adt/rangetypes_gist.c | 29 +++++------------------------
src/backend/utils/adt/tsgistidx.c | 4 ++++
src/backend/utils/adt/tsquery_gist.c | 9 ++++-----
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_amproc.h | 11 -----------
src/include/catalog/pg_proc.h | 16 ----------------
src/test/regress/expected/create_am.out | 6 ++----
src/test/regress/sql/create_am.sql | 6 ++----
10 files changed, 22 insertions(+), 105 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-09-20 04:42:08 pgsql: Accept that server might not be able to send error in crash reco
Previous Message Andres Freund 2017-09-20 02:00:38 Re: pgsql: Make new crash restart test a bit more robust.