pgsql: Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.
Date: 2017-09-06 14:41:15
Message-ID: E1dpbVz-0006y9-3f@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.

The NAMEDTUPLESTORE patch piggybacked on the infrastructure for
TABLEFUNC/VALUES/CTE RTEs, none of which can ever have dropped columns,
so the possibility was ignored most places. Fix that, including adding a
specification to parsenodes.h about what it's supposed to look like.

In passing, clean up assorted comments that hadn't been maintained
properly by said patch.

Per bug #14799 from Philippe Beaudoin. Back-patch to v10.

Discussion: https://postgr.es/m/20170906120005.25630.84360@wrigleys.postgresql.org

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/483882905a9a5dc72c9487ceee12320b9630ba2b

Modified Files
--------------
src/backend/optimizer/util/relnode.c | 4 +-
src/backend/parser/parse_relation.c | 103 +++++++++++++++++++++++------------
src/backend/parser/parse_target.c | 4 +-
src/backend/utils/adt/ruleutils.c | 4 +-
src/include/nodes/parsenodes.h | 5 ++
5 files changed, 79 insertions(+), 41 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-09-06 15:30:34 pgsql: Escape < and & in SGML
Previous Message Tom Lane 2017-09-06 13:38:35 Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.