pgsql: Add a WAIT option to DROP_REPLICATION_SLOT

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Add a WAIT option to DROP_REPLICATION_SLOT
Date: 2017-09-01 12:02:48
Message-ID: E1dnkeu-0007ZF-3c@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add a WAIT option to DROP_REPLICATION_SLOT

Commit 9915de6c1cb2 changed the default behavior of
DROP_REPLICATION_SLOT so that it would wait until any session holding
the slot active would release it, instead of raising an error. But
users are already depending on the original behavior, so revert to it by
default and add a WAIT option to invoke the new behavior.

Per complaint from Simone Gotti, in
Discussion: https://postgr.es/m/CAEvsy6Wgdf90O6pUvg2wSVXL2omH5OPC-38OD4Zzgk-FXavj3Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/be7161566db247fd519e1a888ea8cd36b3c72088

Modified Files
--------------
doc/src/sgml/logicaldecoding.sgml | 2 +-
doc/src/sgml/protocol.sgml | 17 ++++++++++++++---
src/backend/commands/subscriptioncmds.c | 2 +-
src/backend/replication/repl_gram.y | 10 ++++++++++
src/backend/replication/repl_scanner.l | 1 +
src/backend/replication/slotfuncs.c | 2 +-
src/backend/replication/walsender.c | 2 +-
src/include/nodes/replnodes.h | 1 +
8 files changed, 30 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2017-09-01 13:11:47 pgsql: Provisional list of Major Features
Previous Message Simon Riggs 2017-09-01 06:57:42 pgsql: Add note about diskspace usage of pg_commit_ts