pgsql: Fix thinko introduced in 2bef06d516460 et al.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix thinko introduced in 2bef06d516460 et al.
Date: 2017-08-06 21:37:30
Message-ID: E1deTEo-0000oE-DJ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix thinko introduced in 2bef06d516460 et al.

The callers for GetOldestSafeDecodingTransactionId() all inverted the
argument for the argument introduced in 2bef06d516460. Luckily this
appears to be inconsequential for the moment, as we wait for
concurrent in-progress transaction when assembling a
snapshot. Additionally this could only make a difference when adding a
second logical slot, because only a pre-existing slot could cause an
issue by lowering the returned xid dangerously much.

Reported-By: Antonin Houska
Discussion: https://postgr.es/m/32704.1496993134@localhost
Backport: 9.4-, where 2bef06d516460 was backpatched to.

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d68742562ca48decbad57adf0014aaed788ce372

Modified Files
--------------
src/backend/replication/logical/logical.c | 2 +-
src/backend/replication/logical/snapbuild.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-08-06 21:57:21 pgsql: Release notes for 9.6.4, 9.5.8, 9.4.13, 9.3.18, 9.2.22.
Previous Message Andres Freund 2017-08-06 21:37:29 pgsql: Fix thinko introduced in 2bef06d516460 et al.