pgsql: Be more consistent about errors for opfamily member lookup failu

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Be more consistent about errors for opfamily member lookup failu
Date: 2017-07-24 15:23:36
Message-ID: E1dZfCq-0003JD-8t@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Be more consistent about errors for opfamily member lookup failures.

Add error checks in some places that were calling get_opfamily_member
or get_opfamily_proc and just assuming that the call could never fail.
Also, standardize the wording for such errors in some other places.

None of these errors are expected in normal use, hence they're just
elog not ereport. But they may be handy for diagnosing omissions in
custom opclasses.

Rushabh Lathia found the oversight in RelationBuildPartitionKey();
I found the others by grepping for all callers of these functions.

Discussion: https://postgr.es/m/CAGPqQf2R9Nk8htpv0FFi+FP776EwMyGuORpc9zYkZKC8sFQE3g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/278cb4341103e967189997985b09981a73e23a34

Modified Files
--------------
src/backend/catalog/index.c | 4 ++++
src/backend/catalog/partition.c | 7 ++++---
src/backend/executor/execExpr.c | 3 +++
src/backend/executor/execReplication.c | 3 +--
src/backend/executor/nodeIndexscan.c | 3 +++
src/backend/optimizer/path/indxpath.c | 4 ++--
src/backend/optimizer/path/pathkeys.c | 4 ++--
src/backend/optimizer/plan/createplan.c | 7 ++++---
src/backend/utils/cache/relcache.c | 4 ++++
9 files changed, 27 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-07-24 19:17:05 pgsql: Ensure that pg_get_ruledef()'s output matches pg_get_viewdef()'s
Previous Message Noah Misch 2017-07-24 07:17:59 pgsql: MSVC: Finish clean.bat build artifact coverage.