pgsql: Fix pg_dump's handling of event triggers.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_dump's handling of event triggers.
Date: 2017-07-23 00:20:36
Message-ID: E1dZ4dQ-00082Q-VS@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_dump's handling of event triggers.

pg_dump with the --clean option failed to emit DROP EVENT TRIGGER
commands for event triggers. In a closely related oversight,
it also did not emit ALTER OWNER commands for event triggers.
Since only superusers can create event triggers, the latter oversight
is of little practical consequence ... but if we're going to record
an owner for event triggers, then surely pg_dump should preserve it.

Per complaint from Greg Atkins. Back-patch to 9.3 where event triggers
were introduced.

Discussion: https://postgr.es/m/20170722191142.yi4e7tzcg3iacclg@gmail.com

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/82ebda7fffac8f4c796ef7d36d377bebca620528

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 6 ++++--
src/bin/pg_dump/pg_dump.c | 14 ++++++++++++--
src/bin/pg_dump/t/002_pg_dump.pl | 16 ++++++++--------
3 files changed, 24 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2017-07-24 06:55:16 pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.
Previous Message Tom Lane 2017-07-22 22:02:31 pgsql: Improve comments about partitioned hash table freelists.