pgsql: Merge large_object.sql test into largeobject.source.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Merge large_object.sql test into largeobject.source.
Date: 2017-07-17 19:29:01
Message-ID: E1dXBhV-0005uw-8q@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Merge large_object.sql test into largeobject.source.

It seems pretty confusing to have tests named both largeobject and
large_object. The latter is of very recent vintage (commit ff992c074),
so get rid of it in favor of merging into the former.

Also, enable the LO comment test that was added by commit 70ad7ed4e,
since the later commit added the then-missing pg_upgrade functionality.
The large_object.sql test case is almost completely redundant with that,
but not quite: it seems like creating a user-defined LO with an OID in
the system range might be an interesting case for pg_upgrade, so let's
keep it.

Like the earlier patch, back-patch to all supported branches.

Discussion: https://postgr.es/m/18665.1500306372@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a570feaf927b73c5036fa47ea949ca51f2687950

Modified Files
--------------
src/test/regress/expected/large_object.out | 15 ---------------
src/test/regress/input/largeobject.source | 13 +++++++++----
src/test/regress/output/largeobject.source | 16 ++++++++++++----
src/test/regress/output/largeobject_1.source | 16 ++++++++++++----
src/test/regress/parallel_schedule | 2 +-
src/test/regress/serial_schedule | 3 +--
src/test/regress/sql/large_object.sql | 8 --------
7 files changed, 35 insertions(+), 38 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2017-07-17 19:36:05 pgsql: Improve legibility of numeric literal
Previous Message Andrew Dunstan 2017-07-17 19:25:31 pgsql: Use usleep instead of select for timeouts in PostgresNode.pm