pgsql: Improve comments for execExpr.c's handling of FieldStore subexpr

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve comments for execExpr.c's handling of FieldStore subexpr
Date: 2017-07-15 20:57:49
Message-ID: E1dWU8L-0002ca-QZ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve comments for execExpr.c's handling of FieldStore subexpressions.

Given this code's general eagerness to use subexpressions' output variables
as temporary workspace, it's not exactly clear that it is safe for
FieldStore to tell a newval subexpression that it can write into the same
variable that is being supplied as a potential input. Document the chain
of assumptions needed for that to be safe.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/de2af6e001a3d6aeb2a10a802e73af8c7d1d3405

Modified Files
--------------
src/backend/executor/execExpr.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2017-07-16 15:28:32 pgsql: Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f
Previous Message Tom Lane 2017-07-15 18:03:47 pgsql: Improve comments for execExpr.c's isAssignmentIndirectionExpr().