pgsql: Fix pg_basebackup output to stdout on Windows.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_basebackup output to stdout on Windows.
Date: 2017-07-14 13:06:54
Message-ID: E1dW0J4-0007xM-9l@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_basebackup output to stdout on Windows.

When writing a backup to stdout with pg_basebackup on Windows, put stdout
to binary mode. Any CR bytes in the output will otherwise be output
incorrectly as CR+LF.

In the passing, standardize on using "_setmode" instead of "setmode", for
the sake of consistency. They both do the same thing, but according to
MSDN documentation, setmode is deprecated.

Fixes bug #14634, reported by Henry Boehlert. Patch by Haribabu Kommi.
Backpatch to all supported versions.

Discussion: https://www.postgresql.org/message-id/20170428082818.24366.13134@wrigleys.postgresql.org

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cedd25ae8877cb7a465c3b42db7dab20873e162c

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 4 ++++
src/bin/pg_dump/pg_backup_archiver.c | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-07-14 16:27:01 pgsql: Fix broken link-command-line ordering for libpgfeutils.
Previous Message Tom Lane 2017-07-13 23:25:20 pgsql: Fix dumping of FUNCTION RTEs that contain non-function-call expr