From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Minor code review for parse_phrase_operator(). |
Date: | 2017-06-26 14:31:40 |
Message-ID: | E1dPV3E-0000qZ-BO@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Minor code review for parse_phrase_operator().
Fix its header comment, which described the old behavior of the <N>
phrase distance operator; we missed updating that in commit 028350f61.
Also, reset errno before strtol() call, to defend against the possibility
that it was already ERANGE at entry. (The lack of complaints says that
it generally isn't, but this is at least a latent bug.) Very minor
stylistic improvements as well.
Victor Drobny noted the obsolete comment, I noted the errno issue.
Back-patch to 9.6 where this code was added, just in case the errno
issue is a live bug in some cases.
Discussion: https://postgr.es/m/2b5382fdff9b1f79d5eb2c99c4d2cbe2@postgrespro.ru
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9bfb1f2d64c4cab108a69e4bf66da4c2464dcaaf
Modified Files
--------------
src/backend/utils/adt/tsquery.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-06-26 14:43:26 | pgsql: Avoid useless "x = ANY(ARRAY[])" test for empty partition list. |
Previous Message | Magnus Hagander | 2017-06-26 13:35:24 | pgsql: Consistently use () for function calls in release notes |