| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix replication with replica identity full |
| Date: | 2017-06-23 19:43:09 |
| Message-ID: | E1dOUU1-0000cx-6T@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix replication with replica identity full
The comparison with the target rows on the subscriber side was done with
datumIsEqual(), which can have false negatives. For instance, it didn't
work reliably for text columns. So use the equality operator provided
by the type cache instead.
Also add more user documentation about replica identity requirements.
Reported-by: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/08859bb5c2cebc132629ca838113d27bb31b990c
Modified Files
--------------
doc/src/sgml/logical-replication.sgml | 28 +++++++++++++++++++++++-----
src/backend/executor/execReplication.c | 19 ++++++++++++++++---
src/test/subscription/t/001_rep_changes.pl | 23 ++++++++++++++++++++---
3 files changed, 59 insertions(+), 11 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-06-23 20:01:05 | pgsql: Fix incorrect buffer-length argument to uloc_getDisplayName(). |
| Previous Message | Tom Lane | 2017-06-23 18:20:07 | pgsql: Rethink behavior of pg_import_system_collations(). |