pgsql: Adjust pgindent script to use pg_bsd_indent 2.0.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Adjust pgindent script to use pg_bsd_indent 2.0.
Date: 2017-06-21 18:26:29
Message-ID: E1dNkKj-00033C-P7@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Adjust pgindent script to use pg_bsd_indent 2.0.

Update version-checking code and list of switches. Delete obsolete
quasi-support for using GNU indent. Remove a lot of no-longer-needed
workarounds for bugs of the old version, and improve comments for
the hacks that remain. Update run_build() subroutine to fetch the
pg_bsd_indent code from the newly established git repo for it.

In passing, fix pgindent to not overwrite files that require no changes;
this makes it a bit more friendly to run on a built tree.

Adjust relevant documentation.

Remove indent.bsd.patch; it's not relevant anymore (and was obsolete
long ago anyway). Likewise remove pgcppindent, since we're no longer
in the business of shipping C++ code.

Piotr Stefaniak is responsible for most of the algorithmic changes
to the pgindent script; I did the rest.

Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8ff6d4ec7840b0af56f1207073f44b7f2afae96d

Modified Files
--------------
src/tools/pgindent/README | 21 ++-
src/tools/pgindent/indent.bsd.patch | 288 ------------------------------------
src/tools/pgindent/pgcppindent | 29 ----
src/tools/pgindent/pgindent | 157 +++++---------------
src/tools/pgindent/pgindent.man | 5 +-
5 files changed, 52 insertions(+), 448 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-06-21 18:39:16 pgsql: Initial pgindent run with pg_bsd_indent version 2.0.
Previous Message Tom Lane 2017-06-21 18:09:47 pgsql: Final pgindent run with old pg_bsd_indent (version 1.3).