pgAdmin 4 commit: Fix React to work with QtWebKit

From: Dave Page <dpage(at)pgadmin(dot)org>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin 4 commit: Fix React to work with QtWebKit
Date: 2017-06-21 10:25:27
Message-ID: E1dNcpD-0000Th-Ay@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Fix React to work with QtWebKit

We learned that the underlying issue was related to react-dom's SyntheticEvent.augmentClass function being undefined.

This seems to be caused by attempted property assignment after the SyntheticEvent had been replaced by a Proxy of itself. This works fine in Chromium et al, but QtWebKit doesn't deal with Proxy Event objects well.
Moving the augmentClass definition and assignment up above the Proxy stuff resolves the issue in a PR to React: https://github.com/facebook/react/pull/10011

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5cfa22cf23d039c5487055248cf5df0fd9168fc2
Author: George Gelashvili <ggelashvili(at)pivotal(dot)io>

Modified Files
--------------
.../vendor/react-dom/dist/react-dom-server.js | 45 +++++++++++----------
.../vendor/react-dom/dist/react-dom-server.min.js | 16 +-------
.../static/vendor/react-dom/dist/react-dom.js | 45 +++++++++++----------
.../static/vendor/react-dom/dist/react-dom.min.js | 16 +-------
.../static/vendor/react-dom/lib/SyntheticEvent.js | 47 +++++++++++-----------
web/yarn.lock | 14 ++-----
6 files changed, 75 insertions(+), 108 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2017-06-21 10:25:32 Re: [pgAdmin4][PATCH] To fix the issue in Materialized View
Previous Message Murtuza Zabuawala 2017-06-21 10:14:25 Re: [pgAdmin4][PATCH] To fix the issue in Materialized View