From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Teach pgindent to skip files generated by bison or flex automati |
Date: | 2017-06-17 03:14:48 |
Message-ID: | E1dM4CG-0005Hz-T8@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Teach pgindent to skip files generated by bison or flex automatically.
If a .c or .h file corresponds to a .y or .l file, skip indenting it.
There's no point in reindenting derived files, and these files tend to
confuse pgindent. (Which probably indicates a bug in BSD indent, but
I can't get excited about trying to fix it.)
For the same reasons, add src/backend/utils/fmgrtab.c to the set of
files excluded by src/tools/pgindent/exclude_file_patterns.
The point of doing this is that it makes it safe to run pgindent over
the tree without doing "make maintainer-clean" first. While these are
not the only derived .c/.h files in the tree, they are the only ones
pgindent fails on. Removing that prerequisite step results in one less
way to mess up a pgindent run, and it's necessary if we ever hope to get
to the ease of running pgindent via "make indent".
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/cea258b63d9c7a6d0a7c5e91e539bb89df4bc078
Modified Files
--------------
src/tools/pgindent/README | 27 +++++++++++++--------------
src/tools/pgindent/exclude_file_patterns | 5 +++--
src/tools/pgindent/pgindent | 9 +++++++++
3 files changed, 25 insertions(+), 16 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-06-17 04:17:29 | pgsql: Define HAVE_UCOL_STRCOLLUTF8 on Windows |
Previous Message | Peter Eisentraut | 2017-06-17 01:04:58 | pgsql: doc: Add note that COPY commands are published as INSERTs |