| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Improve CREATE SUBSCRIPTION option parsing |
| Date: | 2017-05-18 00:50:21 |
| Message-ID: | E1dB9e1-0001RM-Il@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Improve CREATE SUBSCRIPTION option parsing
When creating a subscription with slot_name = NONE, we failed to check
that also create_slot = false and enabled = false were set. This
created an invalid subscription and could later lead to a crash if a
NULL slot name was accessed. Add more checks around that for
robustness.
Reported-by: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/62345698513cbcb3c48a6dae414abf0f24fd163a
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 14 +++++++++++++-
src/backend/replication/logical/worker.c | 9 +++++++++
src/test/regress/expected/subscription.out | 8 ++++++++
src/test/regress/sql/subscription.sql | 4 ++++
4 files changed, 34 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-05-18 01:20:29 | pgsql: pg_dump: Fix dumping of slot_name = NONE |
| Previous Message | Bruce Momjian | 2017-05-17 23:01:32 | pgsql: Post-PG 10 beta1 pgperltidy run |