| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Guard against null t->tm_zone in strftime.c. |
| Date: | 2017-05-07 16:33:55 |
| Message-ID: | E1d7P87-0008Mh-IP@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Guard against null t->tm_zone in strftime.c.
The upstream IANA code does not guard against null TM_ZONE pointers in this
function, but in our code there is such a check in the other pre-existing
use of t->tm_zone. We do have some places that set pg_tm.tm_zone to NULL.
I'm not entirely sure it's possible to reach strftime with such a value,
but I'm not sure it isn't either, so be safe.
Per Coverity complaint.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a54d5875fe0bc19d05236b85e1e1bf0af9fa2902
Modified Files
--------------
src/timezone/strftime.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2017-05-07 16:58:51 | pgsql: Fix memory leaks if random salt generation fails. |
| Previous Message | Tom Lane | 2017-05-07 15:58:01 | pgsql: Install the "posixrules" timezone link in MSVC builds. |