pgsql: Remove useless and rather expensive stanza in matview regression

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove useless and rather expensive stanza in matview regression
Date: 2017-05-03 23:37:24
Message-ID: E1d63pk-0003Vo-Qd@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove useless and rather expensive stanza in matview regression test.

This removes a test case added by commit b69ec7cc9, which was intended
to exercise a corner case involving the rule used at that time that
materialized views were unpopulated iff they had physical size zero.
We got rid of that rule very shortly later, in commit 1d6c72a55, but
kept the test case. However, because the case now asks what VACUUM
will do to a zero-sized physical file, it would be pretty surprising
if the answer were ever anything but "nothing" ... and if things were
indeed that broken, surely we'd find it out from other tests. Since
the test involves a table that's fairly large by regression-test
standards (100K rows), it's quite slow to run. Dropping it should
save some buildfarm cycles, so let's do that.

Discussion: https://postgr.es/m/32386.1493831320@sss.pgh.pa.us

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2ffe80c06ab353f29a51df25f6db13e7ddefb16f

Modified Files
--------------
src/test/regress/expected/matview.out | 20 --------------------
src/test/regress/sql/matview.sql | 12 ------------
2 files changed, 32 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-05-04 01:53:13 pgsql: Fix cursor_to_xml in tableforest false mode
Previous Message Alvaro Herrera 2017-05-03 18:54:34 pgsql: Add pg_dump tests for CREATE STATISTICS