pgsql: postgres_fdw: Fix join push down with extensions

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: postgres_fdw: Fix join push down with extensions
Date: 2017-04-25 02:50:07
Message-ID: E1d2qYJ-0008Uw-BE@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Fix join push down with extensions

Objects in an extension are shippable to a foreign server if the
extension is part of the foreign server definition's shippable
extensions list. But this was not properly considered in some cases
when checking whether a join condition can be pushed to a foreign server
and the join condition uses an object from a shippable extension. So
the join would never be pushed down in those cases.

So, the list of extensions needs to be made available in fpinfo of the
relation being considered to be pushed down before any expressions are
assessed for being shippable. Fix foreign_join_ok() to do that for a
join relation.

The code to save FDW options in fpinfo is scattered at multiple places.
Bring all of that together into functions apply_server_options(),
apply_table_options(), and merge_fdw_options().

David Rowley and Ashutosh Bapat, per report from David Rowley

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/332bec1e6096679b04ec9717beb44a858495260f

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 29 ++++
contrib/postgres_fdw/postgres_fdw.c | 195 ++++++++++++++++---------
contrib/postgres_fdw/sql/postgres_fdw.sql | 8 +
3 files changed, 160 insertions(+), 72 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2017-04-25 02:51:30 pgsql: doc: merge PG 10 release SysV item
Previous Message Bruce Momjian 2017-04-25 02:48:35 pgsql: doc: PG 10 fixes