From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix order of arguments to SubTransSetParent(). |
Date: | 2017-04-23 17:11:24 |
Message-ID: | E1d2L2i-0004F9-DA@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix order of arguments to SubTransSetParent().
ProcessTwoPhaseBuffer (formerly StandbyRecoverPreparedTransactions)
mixed up the parent and child XIDs when calling SubTransSetParent to
record the transactions' relationship in pg_subtrans.
Remarkably, analysis by Simon Riggs suggests that this doesn't lead to
visible problems (at least, not in non-Assert builds). That might
explain why we'd not noticed it before. Nonetheless, it's surely wrong.
This code was born broken, so back-patch to all supported branches.
Discussion: https://postgr.es/m/20110.1492905318@sss.pgh.pa.us
Branch
------
REL9_4_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/2e14541c4992e5a2de6b5be2f7ed3f3062ed4ec1
Modified Files
--------------
src/backend/access/transam/twophase.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2017-04-23 20:52:07 | pgsql: Fix LagTrackerRead() for timeline increments |
Previous Message | Andrew Dunstan | 2017-04-23 13:42:11 | pgsql: Fix TAP infrastructure to support Mingw better |