| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Partially revert commit 536d47bd9d5fce8d91929bee3128fa1d08dbcc57 |
| Date: | 2017-04-22 06:07:03 |
| Message-ID: | E1d1oCF-00073F-O5@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Partially revert commit 536d47bd9d5fce8d91929bee3128fa1d08dbcc57.
Per buildfarm, the "#ifdef F_SETFD" removed in that commit actually
is needed on Windows, because fcntl() isn't available at all on that
platform, unless using Cygwin. We could perhaps spell it more like
"#ifdef HAVE_FCNTL", or "#ifndef WIN32", but it's not clear that
those choices are better.
It does seem that we don't need the bogus manual definition of
FD_CLOEXEC, though, so keep that change.
Discussion: https://postgr.es/m/26254.1492805635@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5041cdf2b79216b10ca90498d9a9b8fd4abf1745
Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 2 ++
1 file changed, 2 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2017-04-22 09:13:44 | Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders |
| Previous Message | Thomas Munro | 2017-04-22 05:45:15 | Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders |