pgsql: Mark some columns in pg_subscription as NOT NULL.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Mark some columns in pg_subscription as NOT NULL.
Date: 2017-04-20 14:36:17
Message-ID: E1d1DBx-0003N4-PK@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Mark some columns in pg_subscription as NOT NULL.

In pg_subscription, subconninfo, subslotname, subsynccommit and
subpublications are expected not to be NULL. Therefore this patch
adds BKI_FORCE_NOT_NULL markings to them.

This patch is basically unnecessary unless the code has a bug which
wrongly sets either of those columns to NULL. But it's good to have
this as a safeguard.

Author: Masahiko Sawada
Reviewed-by: Kyotaro Horiguchi
Reported-by: Fujii Masao
Discussion: http://postgr.es/m/CAHGQGwFDWh_Qr-q_GEMpD+qH=vYPMdVqw=ZOSY3kX_Pna9R9SA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/88b0a31926331eb5336ec92010b3b4f7e6efb53c

Modified Files
--------------
src/include/catalog/pg_subscription.h | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2017-04-20 15:57:53 pgsql: Prevent log_replication_commands from causing SQL commands to be
Previous Message Fujii Masao 2017-04-20 14:13:39 pgsql: Don't call the function that may raise an error while holding sp