pgsql: A collection of small fixes for logical replication.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: A collection of small fixes for logical replication.
Date: 2017-04-18 17:17:23
Message-ID: E1d0Wkl-0003BD-1U@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

A collection of small fixes for logical replication.

* Be sure to reset the launcher's pid (LogicalRepCtx->launcher_pid) to 0
even when the launcher emits an error.

* Declare ApplyLauncherWakeup() as a static function because it's called
only in launcher.c.

* Previously IsBackendPId() was used to check whether the launcher's pid
was valid. IsBackendPid() was necessary because there was the bug where
the launcher's pid was not reset to 0. But now it's fixed, so IsBackendPid()
is not necessary and this patch removes it.

Author: Masahiko Sawada
Reviewed-by: Kyotaro Horiguchi
Reported-by: Fujii Masao
Discussion: http://postgr.es/m/CAHGQGwFDWh_Qr-q_GEMpD+qH=vYPMdVqw=ZOSY3kX_Pna9R9SA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/280c53ecfbcad442c4b5eaab4cc3e65408f486eb

Modified Files
--------------
src/backend/replication/logical/launcher.c | 19 +++++++++++++++++--
src/include/replication/logicallauncher.h | 1 -
2 files changed, 17 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-04-18 17:21:33 pgsql: Provide an error cursor for "can't call an SRF here" errors.
Previous Message Fujii Masao 2017-04-18 15:12:53 pgsql: Use DatumGetInt32() to extract 32-bit integer value from a datum