| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Dont push nextid too far forwards in recovery |
| Date: | 2017-04-18 10:31:51 |
| Message-ID: | E1d0QQJ-0003xI-KV@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Don’t push nextid too far forwards in recovery
Doing so allows various crash possibilities. Fix by avoiding
having PrescanPreparedTransactions() increment
ShmemVariableCache->nextXid when it has no 2PC files
Bug found by Jeff Janes, diagnosis and patch by Pavan Deolasee,
then patch re-designed for clarity and full accuracy by
Michael Paquier.
Reported-by: Jeff Janes
Author: Pavan Deolasee, Michael Paquier
Discussion: https://postgr.es/m/CAMkU=1zMLnH_i1-PVQ-biZzvNx7VcuatriquEnh7HNk6K8Ss3Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/aa203e76004daaee3d70b19cc727ed17b87b3d3a
Modified Files
--------------
src/backend/access/transam/twophase.c | 77 ++++++++++++++++-------------------
1 file changed, 36 insertions(+), 41 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2017-04-18 10:52:37 | pgsql: Exit correctly from PrepareRedoRemove() when not found |
| Previous Message | Simon Riggs | 2017-04-18 09:45:32 | pgsql: Allow COMMENT ON COLUMN with partitioned tables |