pgsql: Tighten up relation kind checks for extended statistics

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Tighten up relation kind checks for extended statistics
Date: 2017-04-17 20:58:00
Message-ID: E1d0Dii-0005Zd-SM@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tighten up relation kind checks for extended statistics

We were accepting creation of extended statistics only for regular
tables, but they can usefully be created for foreign tables, partitioned
tables, and materialized views, too. Allow those cases.

While at it, make sure all the rejected cases throw a consistent error
message, and add regression tests for the whole thing.

Author: David Rowley, Álvaro Herrera
Discussion: https://postgr.es/m/CAKJS1f-BmGo410bh5RSPZUvOO0LhmHL2NYmdrC_Jm8pk_FfyCA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8c5cdb7f4f6e1d6a6104cb58ce4f23453891651b

Modified Files
--------------
doc/src/sgml/ref/create_statistics.sgml | 2 +-
src/backend/commands/statscmds.c | 10 +++++----
src/bin/pg_dump/pg_dump.c | 9 ++++++--
src/test/regress/expected/stats_ext.out | 40 +++++++++++++++++++++++++++++++++
src/test/regress/sql/stats_ext.sql | 38 +++++++++++++++++++++++++++++++
5 files changed, 92 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2017-04-17 21:37:37 pgsql: Rename columns in new pg_statistic_ext catalog
Previous Message Tom Lane 2017-04-17 19:29:22 pgsql: Always build a custom plan node's targetlist from the path's pat