From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix pageinspect failures on hash indexes. |
Date: | 2017-04-05 18:20:06 |
Message-ID: | E1cvpXK-00047h-8G@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix pageinspect failures on hash indexes.
Make every page in a hash index which isn't all-zeroes have a valid
special space, so that tools like pageinspect don't error out.
Also, make pageinspect cope with all-zeroes pages, because
_hash_alloc_buckets can leave behind large numbers of those until
they're consumed by splits.
Ashutosh Sharma and Robert Haas, reviewed by Amit Kapila.
Original trouble report from Jeff Janes.
Discussion: http://postgr.es/m/CAMkU=1y6NjKmqbJ8wLMhr=F74WzcMALYWcVFhEpm7i=mV=XsOg@mail.gmail.com
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/633e15ea0f1bf2e1d70441fe9da8781befebd6e9
Modified Files
--------------
contrib/pageinspect/hashfuncs.c | 70 +++++++++++++++++++++----------------
src/backend/access/hash/hash_xlog.c | 9 +++++
src/backend/access/hash/hashovfl.c | 17 +++++++--
src/backend/access/hash/hashpage.c | 12 ++++++-
4 files changed, 73 insertions(+), 35 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2017-04-05 18:30:52 | pgsql: Spelling mistake in comment in utility.c |
Previous Message | Peter Eisentraut | 2017-04-05 18:07:05 | pgsql: Use American English in error message |