pgsql: Avoid GatherMerge crash when there are no workers.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Avoid GatherMerge crash when there are no workers.
Date: 2017-04-01 01:22:14
Message-ID: E1cu7k6-00024s-W3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Avoid GatherMerge crash when there are no workers.

It's unnecessary to return an actual slot when we have no tuple.
We can just return NULL, which avoids the risk of indexing into an
array that might not contain any elements.

Rushabh Lathia, per a report from Tomas Vondra

Discussion: http://postgr.es/m/6ecd6f17-0dcf-1de7-ded8-0de7db1ddc88@2ndquadrant.com

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/25dc142a49c60c3107480c487cd8444dc83f9bdf

Modified Files
--------------
src/backend/executor/nodeGatherMerge.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-04-01 02:26:05 Re: [COMMITTERS] pgsql: Avoid GatherMerge crash when there are no workers.
Previous Message Robert Haas 2017-04-01 01:13:26 pgsql: Fix parallel query so it doesn't spoil row estimates above Gathe

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2017-04-01 01:26:01 Re: logical replication launcher crash on buildfarm
Previous Message Robert Haas 2017-04-01 00:57:28 Re: TPC-H Q20 from 1 hour to 19 hours!