From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Suppress implicit-conversion warnings seen with newer clang vers |
Date: | 2017-03-28 17:16:34 |
Message-ID: | E1csujS-0003d2-5E@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Suppress implicit-conversion warnings seen with newer clang versions.
We were assigning values near 255 through "char *" pointers. On machines
where char is signed, that's not entirely kosher, and it's reasonable
for compilers to warn about it.
A better solution would be to change the pointer type to "unsigned char *",
but that would be vastly more invasive. For the moment, let's just apply
this simple backpatchable solution.
Aleksander Alekseev
Discussion: https://postgr.es/m/20170220141239.GD12278@e733.localdomain
Discussion: https://postgr.es/m/2839.1490714708@sss.pgh.pa.us
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/8cfeaecfc76a7366b336272bc76e96e09281b133
Modified Files
--------------
src/backend/access/transam/xlog.c | 2 +-
src/backend/access/transam/xloginsert.c | 6 +++---
src/bin/pg_resetwal/pg_resetwal.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-03-28 17:23:53 | pgsql: Fix ssl tests |
Previous Message | Fujii Masao | 2017-03-28 16:33:55 | Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin |