pgsql: Improve implementation of EEOP_BOOLTEST_* opcodes.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve implementation of EEOP_BOOLTEST_* opcodes.
Date: 2017-03-26 19:57:07
Message-ID: E1csEHj-0001xb-Ap@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve implementation of EEOP_BOOLTEST_* opcodes.

Both Andres and I were happy with "*op->resvalue = *op->resvalue;",
but Coverity isn't; and it has a point, because some compilers might
not be smart enough to elide that. So remove it. In passing, also
avoid doing unnecessary assignments to *op->resnull when it's already
known to have the right value.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d77f014efa7eda4357fbc851dbf25c6b256ddf35

Modified Files
--------------
src/backend/executor/execExprInterp.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-03-26 21:35:58 pgsql: Fix unportable disregard of alignment requirements in RADIUS cod
Previous Message Peter Eisentraut 2017-03-26 19:04:31 pgsql: doc: Fix oldhtml/old PDF build