pgsql: Fix hard-coded relkind constants in assorted other files.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix hard-coded relkind constants in assorted other files.
Date: 2017-03-10 04:37:00
Message-ID: E1cmCIW-0002sq-GF@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix hard-coded relkind constants in assorted other files.

Although it's reasonable to expect that most of these constants will
never change, that does not make it good programming style to hard-code
the value rather than using the RELKIND_FOO macros.

I think I've now gotten all the hard-coded references in C code.
Unfortunately there's no equally convenient way to parameterize
SQL files ...

Discussion: https://postgr.es/m/11145.1488931324@sss.pgh.pa.us

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/9c2635e26f6f4e34b3b606c0fc79d0e111953a74

Modified Files
--------------
contrib/oid2name/oid2name.c | 17 ++++++++++++-----
contrib/postgres_fdw/postgres_fdw.c | 7 ++++++-
contrib/vacuumlo/vacuumlo.c | 4 +++-
src/backend/utils/adt/xml.c | 17 +++++++++++++++--
src/tools/findoidjoins/findoidjoins.c | 20 ++++++++++++--------
5 files changed, 48 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-03-10 04:50:27 Re: pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.
Previous Message Andres Freund 2017-03-10 04:04:32 pgsql: amcheck: editorialize variable name & comment.