From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Remove vestigial grammar support for CHARACTER ... CHARACTER SET |
Date: | 2017-03-07 15:42:28 |
Message-ID: | E1clHFs-0006eO-UH@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Remove vestigial grammar support for CHARACTER ... CHARACTER SET option.
The SQL standard says that you should be able to write "CHARACTER SET foo"
as part of the declaration of a char-type column. We don't implement that,
but a rough form of support has existed in gram.y since commit f10b63923.
That's now sat there for nigh 20 years without anyone fleshing it out ---
and even if someone did, the contemplated approach of having separate data
type name(s) for every character set certainly isn't what we'd do today.
Let's just remove the grammar production; if anyone is ever motivated to
work on this, reinventing the grammar support is a trivial fraction of
what they'd have to do. And we've never documented anything about
supporting such a clause.
Per gripe from Neha Khatri.
Discussion: https://postgr.es/m/CAFO0U+-iOS5oYN5v3SBuZvfhPUTRrkDFEx8w7H17B07Rwg3YUA@mail.gmail.com
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/11324e408f0e3a25621c611467927c644894b30d
Modified Files
--------------
src/backend/parser/gram.y | 18 ++----------------
1 file changed, 2 insertions(+), 16 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-03-07 15:44:29 | pgsql: Fix wrong word in comment. |
Previous Message | Robert Haas | 2017-03-07 15:38:34 | pgsql: Preparatory refactoring for parallel merge join support. |