pgsql: Improve error reporting for tuple-routing failures.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Improve error reporting for tuple-routing failures.
Date: 2017-03-03 03:42:11
Message-ID: E1cje6d-0006TN-91@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve error reporting for tuple-routing failures.

Currently, the whole row is shown without column names. Instead,
adopt a style similar to _bt_check_unique() in ExecFindPartition()
and show the failing key: (key1, ...) = (val1, ...).

Amit Langote, per a complaint from Simon Riggs. Reviewed by me;
I also adjusted the grammar in one of the comments.

Discussion: http://postgr.es/m/9f9dc7ae-14f0-4a25-5485-964d9bfc19bd@lab.ntt.co.jp

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5a73e17317e91912b2755f7960d5bf31d374cf31

Modified Files
--------------
src/backend/access/index/genam.c | 4 ++
src/backend/catalog/partition.c | 30 ++++----
src/backend/executor/execMain.c | 132 ++++++++++++++++++++++++++++++-----
src/backend/utils/adt/ruleutils.c | 37 +++++++---
src/include/catalog/partition.h | 8 ++-
src/include/utils/ruleutils.h | 2 +
src/test/regress/expected/insert.out | 38 ++++++++--
src/test/regress/sql/insert.sql | 30 ++++++++
8 files changed, 231 insertions(+), 50 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-03-03 03:57:47 pgsql: Notify bgworker registrant after freeing worker slot.
Previous Message Peter Eisentraut 2017-03-02 16:10:09 pgsql: Correct old release note item