pgsql: Handle unaligned SerializeSnapshot() buffer.

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Handle unaligned SerializeSnapshot() buffer.
Date: 2017-03-02 05:04:36
Message-ID: E1cjIuq-0007Sp-Bs@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Handle unaligned SerializeSnapshot() buffer.

Likewise in RestoreSnapshot(). Do so by copying between the user buffer
and a stack buffer of known alignment. Back-patch to 9.6, where this
last applies cleanly. In master, the select_parallel test dies with
SIGBUS on "Oracle Solaris 10 1/13 s10s_u11wos_24a SPARC", building
32-bit with gcc 4.9.2. In 9.6 and 9.5, the buffers in question happen
to be sufficiently-aligned, and this change is mere insurance against
future 9.6 changes or extension code compromising that.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7f3112135eb67e5df56cd34b8ce662bf6a2390e9

Modified Files
--------------
src/backend/utils/time/snapmgr.c | 76 +++++++++++++++++++++-------------------
1 file changed, 40 insertions(+), 36 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-03-02 11:39:46 pgsql: Update comments overlooked by 2f5c9d9c9cec436e55847ec580606d7e88
Previous Message Alvaro Herrera 2017-03-01 22:28:48 pgsql: Create <sect3> in the functions-xml section