| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix unportable definition of BSWAP64() macro. |
| Date: | 2017-02-24 20:21:47 |
| Message-ID: | E1chMN9-0004Nb-KN@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix unportable definition of BSWAP64() macro.
We have a portable way of writing uint64 constants, but whoever wrote
this macro didn't know about it.
While at it, fix unsafe under-parenthesization of arguments. That might
be moot, because there are already good reasons not to use the macro on
anything more complicated than a simple variable, but it's still poor
practice.
Per buildfarm warnings.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/41c16edcf6c90d1f42810ea523b7e65c99edad50
Modified Files
--------------
src/include/port/pg_bswap.h | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-02-24 21:45:38 | pgsql: Suppress compiler warnings in ecpg test on newer Windows toolcha |
| Previous Message | Robert Haas | 2017-02-24 06:53:51 | pgsql: Make tablesample work with partitioned tables. |