| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> | 
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org | 
| Subject: | pgsql: Remove pg_control's enableIntTimes field. | 
| Date: | 2017-02-23 17:23:18 | 
| Message-ID: | E1cgx6s-0004x3-3a@gemulon.postgresql.org | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-committers | 
Remove pg_control's enableIntTimes field.
We don't need it any more.
pg_controldata continues to report that date/time type storage is
"64-bit integers", but that's now a hard-wired behavior not something
it sees in the data.  This avoids breaking pg_upgrade, and perhaps other
utilities that inspect pg_control this way.  Ditto for pg_resetwal.
I chose to remove the "bigint_timestamps" output column of
pg_control_init(), though, as that function hasn't been around long
and probably doesn't have ossified users.
Discussion: https://postgr.es/m/26788.1487455319@sss.pgh.pa.us
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/d28aafb6dda326688e2f042c95c93ea57963c03c
Modified Files
--------------
doc/src/sgml/func.sgml                  |  5 -----
src/backend/access/transam/xlog.c       | 21 ---------------------
src/backend/utils/misc/pg_controldata.c | 23 +++++++++--------------
src/bin/pg_controldata/pg_controldata.c |  3 ++-
src/bin/pg_resetwal/pg_resetwal.c       |  8 ++------
src/include/catalog/catversion.h        |  2 +-
src/include/catalog/pg_control.h        |  5 +----
src/include/catalog/pg_proc.h           |  2 +-
8 files changed, 16 insertions(+), 53 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-02-23 19:04:49 | pgsql: Remove now-dead code for !HAVE_INT64_TIMESTAMP. | 
| Previous Message | Tom Lane | 2017-02-23 16:40:28 | pgsql: De-support floating-point timestamps. |