From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Suppress "unused variable" warnings with older versions of flex. |
Date: | 2017-02-19 18:04:36 |
Message-ID: | E1cfVqe-0004US-BS@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Suppress "unused variable" warnings with older versions of flex.
Versions of flex before 2.5.36 might generate code that results in an
"unused variable" warning, when using %option reentrant. Historically
we've worked around that by specifying -Wno-error, but that's an
unsatisfying solution. The official "fix" for this was just to insert a
dummy reference to the variable, so write a small perl script that edits
the generated C code similarly.
The MSVC side of this is untested, but the buildfarm should soon reveal
if I broke that.
Discussion: https://postgr.es/m/25456.1487437842@sss.pgh.pa.us
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/65d508fd4decee4d5a54c1e7b93acd25d5e80556
Modified Files
--------------
src/Makefile.global.in | 1 +
src/backend/parser/Makefile | 7 +----
src/bin/psql/Makefile | 6 +---
src/fe_utils/Makefile | 6 +---
src/tools/fix-flex-warning.pl | 65 +++++++++++++++++++++++++++++++++++++++++++
src/tools/msvc/pgflex.pl | 20 ++++++++-----
6 files changed, 82 insertions(+), 23 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-02-19 21:15:16 | pgsql: Adjust PL/Tcl regression test to dodge a possible bug or zone de |
Previous Message | Robert Haas | 2017-02-19 16:01:48 | pgsql: Make partitions automatically inherit OIDs. |