From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix tab completion for "ALTER SYSTEM SET variable ...". |
Date: | 2017-02-15 20:23:26 |
Message-ID: | E1ce66o-00065E-PL@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix tab completion for "ALTER SYSTEM SET variable ...".
It wouldn't complete "TO" after the variable name, which is certainly
minor enough. But since we do complete "TO" after "SET variable ...",
and since this case used to work pre-9.6, I think this is a bug.
Also, fix the query used to collect the variable names; whoever last
touched it evidently didn't understand how the pieces are supposed
to fit together. It accidentally worked anyway, because readline
ignores irrelevant completions, but it was randomly unlike the ones
around it, and could be a source of actual bugs if someone copied
it as a prototype for another query.
Branch
------
REL9_6_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/a3f4c8e50e8e00fc88c44d5ff7a99c1ce88256be
Modified Files
--------------
src/bin/psql/tab-complete.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-02-15 20:41:22 | pgsql: Doc: fix syntax synopsis for INSERT ... ON CONFLICT DO UPDATE. |
Previous Message | Tom Lane | 2017-02-15 19:44:33 | pgsql: Fix YA unwanted behavioral difference with operator_precedence_w |