pgsql: Split index xlog headers from other private index headers.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Split index xlog headers from other private index headers.
Date: 2017-02-14 20:47:49
Message-ID: E1cdk0r-000683-2E@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Split index xlog headers from other private index headers.

The xlog-specific headers need to be included in both frontend code -
specifically, pg_waldump - and the backend, but the remainder of the
private headers for each index are only needed by the backend. By
splitting the xlog stuff out into separate headers, pg_waldump pulls
in fewer backend headers, which is a good thing.

Patch by me, reviewed by Michael Paquier and Andres Freund, per a
complaint from Dilip Kumar.

Discussion: http://postgr.es/m/CA+TgmoZ=F=GkxV0YEv-A8tb+AEGy_Qa7GSiJ8deBKFATnzfEug@mail.gmail.com

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8da9a226369e9ceec7cef1ab7a16cdc0adb4d657

Modified Files
--------------
src/backend/access/gin/ginbtree.c | 1 +
src/backend/access/gin/gindatapage.c | 1 +
src/backend/access/gin/ginentrypage.c | 1 +
src/backend/access/gin/ginfast.c | 1 +
src/backend/access/gin/gininsert.c | 1 +
src/backend/access/gin/ginutil.c | 1 +
src/backend/access/gin/ginvacuum.c | 1 +
src/backend/access/gin/ginxlog.c | 1 +
src/backend/access/gist/gistbuild.c | 1 +
src/backend/access/gist/gistxlog.c | 1 +
src/backend/access/nbtree/nbtinsert.c | 1 +
src/backend/access/nbtree/nbtpage.c | 1 +
src/backend/access/nbtree/nbtxlog.c | 1 +
src/backend/access/rmgrdesc/gindesc.c | 2 +-
src/backend/access/rmgrdesc/gistdesc.c | 2 +-
src/backend/access/rmgrdesc/nbtdesc.c | 2 +-
src/backend/access/rmgrdesc/spgdesc.c | 2 +-
src/backend/access/spgist/spgdoinsert.c | 1 +
src/backend/access/spgist/spginsert.c | 1 +
src/backend/access/spgist/spgvacuum.c | 1 +
src/backend/access/spgist/spgxlog.c | 1 +
src/backend/access/transam/rmgr.c | 8 +-
src/bin/pg_waldump/rmgrdesc.c | 8 +-
src/include/access/gin.h | 8 -
src/include/access/gin_private.h | 509 +-------------------------------
src/include/access/ginblock.h | 329 +++++++++++++++++++++
src/include/access/ginxlog.h | 217 ++++++++++++++
src/include/access/gist_private.h | 55 +---
src/include/access/gistxlog.h | 69 +++++
src/include/access/hash_xlog.h | 2 +-
src/include/access/nbtree.h | 234 ---------------
src/include/access/nbtxlog.h | 255 ++++++++++++++++
src/include/access/spgist.h | 8 -
src/include/access/spgist_private.h | 230 ---------------
src/include/access/spgxlog.h | 257 ++++++++++++++++
35 files changed, 1159 insertions(+), 1055 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-02-14 23:16:19 pgsql: Allow parallel workers to execute subplans.
Previous Message Robert Haas 2017-02-14 17:43:47 pgsql: Minor fixes for WAL consistency checking.