pgsql: Get rid of ParseState.p_value_substitute; use a columnref hook i

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Get rid of ParseState.p_value_substitute; use a columnref hook i
Date: 2017-01-07 21:02:34
Message-ID: E1cPy8I-0007KL-FQ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Get rid of ParseState.p_value_substitute; use a columnref hook instead.

I noticed that p_value_substitute, which is a single-purpose kluge I added
in 2002 (commit b0422b215), could be replaced by having domainAddConstraint
install a parser hook that looks for the name "value". The parser hook
code only dates back to 2009, so it's not surprising that we had to kluge
this in 2002, but we can do it more cleanly now.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7c3abe3c92fd3a14a70bc2f888f936cd6fe28c0f

Modified Files
--------------
src/backend/commands/typecmds.c | 34 +++++++++++++++++++++++++++++++++-
src/backend/parser/parse_expr.c | 21 ---------------------
src/include/parser/parse_node.h | 4 ----
3 files changed, 33 insertions(+), 26 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2017-01-09 15:05:11 pgsql: Use an enum instead of two bools to indicate wal inclusion in ba
Previous Message Stephen Frost 2017-01-06 21:29:48 pgsql: Add basic pg_dumpall/pg_restore TAP tests