From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Use TSConfigRelationId in AlterTSConfiguration() |
Date: | 2016-12-22 22:09:38 |
Message-ID: | E1cKBYQ-0006Ai-Nv@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Use TSConfigRelationId in AlterTSConfiguration()
When we are altering a text search configuration, we are getting the
tuple from pg_ts_config and using its OID, so use TSConfigRelationId
when invoking any post-alter hooks and setting the object address.
Further, in the functions called from AlterTSConfiguration(), we're
saving information about the command via
EventTriggerCollectAlterTSConfig(), so we should be setting
commandCollected to true. Also add a regression test to
test_ddl_deparse for ALTER TEXT SEARCH CONFIGURATION.
Author: Artur Zakirov, a few additional comments by me
Discussion: https://www.postgresql.org/message-id/57a71eba-f2c7-e7fd-6fc0-2126ec0b39bd%40postgrespro.ru
Back-patch the fix for the InvokeObjectPostAlterHook() call to 9.3 where
it was introduced, and the fix for the ObjectAddressSet() call and
setting commandCollected to true to 9.5 where those changes to
ProcessUtilitySlow() were introduced.
Branch
------
REL9_6_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/f0f2e56ac28c05f930ca76c432d61909c9a12cdb
Modified Files
--------------
src/backend/commands/tsearchcmds.c | 4 ++--
src/backend/tcop/utility.c | 8 +++++++-
src/test/modules/test_ddl_deparse/Makefile | 1 +
src/test/modules/test_ddl_deparse/expected/alter_ts_config.out | 8 ++++++++
src/test/modules/test_ddl_deparse/sql/alter_ts_config.sql | 8 ++++++++
5 files changed, 26 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-12-22 22:20:53 | Re: pgsql: Use TSConfigRelationId in AlterTSConfiguration() |
Previous Message | Tom Lane | 2016-12-22 21:23:52 | pgsql: Fix CREATE TABLE ... LIKE ... WITH OIDS. |