pgsql: Make dblink try harder to form useful error messages

From: Joe Conway <mail(at)joeconway(dot)com>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make dblink try harder to form useful error messages
Date: 2016-12-22 17:49:20
Message-ID: E1cK7UW-0001Rg-90@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make dblink try harder to form useful error messages

When libpq encounters a connection-level error, e.g. runs out of memory
while forming a result, there will be no error associated with PGresult,
but a message will be placed into PGconn's error buffer. postgres_fdw
takes care to use the PGconn error message when PGresult does not have
one, but dblink has been negligent in that regard. Modify dblink to mirror
what postgres_fdw has been doing.

Back-patch to all supported branches.

Author: Joe Conway
Reviewed-By: Tom Lane
Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/76943f54a743e3d7875a6772fec89bb57a8f2118

Modified Files
--------------
contrib/dblink/dblink.c | 31 ++++++++++++++++++++++---------
1 file changed, 22 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Joe Conway 2016-12-22 17:49:24 pgsql: Make dblink try harder to form useful error messages
Previous Message Joe Conway 2016-12-22 17:49:15 pgsql: Make dblink try harder to form useful error messages