From: | Joe Conway <mail(at)joeconway(dot)com> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Make dblink try harder to form useful error messages |
Date: | 2016-12-22 17:49:06 |
Message-ID: | E1cK7UI-0001QZ-3p@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Make dblink try harder to form useful error messages
When libpq encounters a connection-level error, e.g. runs out of memory
while forming a result, there will be no error associated with PGresult,
but a message will be placed into PGconn's error buffer. postgres_fdw
takes care to use the PGconn error message when PGresult does not have
one, but dblink has been negligent in that regard. Modify dblink to mirror
what postgres_fdw has been doing.
Back-patch to all supported branches.
Author: Joe Conway
Reviewed-By: Tom Lane
Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/2f802d95b4904dbed3dfdca1b3a607cd085d2e20
Modified Files
--------------
contrib/dblink/dblink.c | 31 ++++++++++++++++++++++---------
1 file changed, 22 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Conway | 2016-12-22 17:49:10 | pgsql: Make dblink try harder to form useful error messages |
Previous Message | Robert Haas | 2016-12-22 17:46:06 | pgsql: Code review for ATExecAttachPartition. |