pgAdmin 4 commit: Minimise memory requirements for rendered cells and r

From: Dave Page <dpage(at)pgadmin(dot)org>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin 4 commit: Minimise memory requirements for rendered cells and r
Date: 2016-12-22 17:43:52
Message-ID: E1cK7PE-0005PV-Ey@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Minimise memory requirements for rendered cells and rows in SlickGrid. Fixes #2035

- The CSS class 'slick-row' has been renamed to 'sr'

- The CSS class 'slick-cell' has been renamed to 'sc'

- The SQL Editor included an unused 'normal_row' class on each row which has been removed as it was unreferenced in the code or CSS.

The intent of these changes is to minimise memory usage by the grid, by saving a few bytes per row/cell.
It's questionable how much difference this actually makes given that SlickGrid updates the document so it
only includes the visible rows on the fly, but every little helps.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=87d49377261c9a6fa92bd19dc045740bc68eb701

Modified Files
--------------
.../static/css/slickgrid/slick-default-theme.css | 20 +++++++++---------
web/pgadmin/static/css/slickgrid/slick.grid.css | 12 +++++------
web/pgadmin/static/js/slickgrid/README | 9 ++++++++
web/pgadmin/static/js/slickgrid/slick.grid.js | 24 +++++++++++-----------
.../tools/sqleditor/static/css/sqleditor.css | 14 ++++++-------
.../sqleditor/templates/sqleditor/js/sqleditor.js | 4 ++--
6 files changed, 46 insertions(+), 37 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2016-12-23 05:54:54 Re: [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"
Previous Message Dave Page 2016-12-21 13:17:33 Re: PATCH: To fix the issue in Notes control (pgAdmin4)