pgsql: In contrib/uuid-ossp, #include headers needed for ntohl() and nt

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: In contrib/uuid-ossp, #include headers needed for ntohl() and nt
Date: 2016-12-18 03:25:05
Message-ID: E1cIS5x-0001v4-I0@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In contrib/uuid-ossp, #include headers needed for ntohl() and ntohs().

Oversight in commit b8cc8f947. I just noticed this causes compiler
warnings on FreeBSD, and it really ought to cause warnings elsewhere too:
all references I can find say that <arpa/inet.h> is required for these.
We have a lot of code elsewhere that thinks that both <netinet/in.h>
and <arpa/inet.h> should be included for these functions, so do it that
way here too, even though <arpa/inet.h> ought to be sufficient according
to the references I consulted.

Back-patch to 9.4 where the previous commit landed.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/20c27fdfd3af8da68837ab1cbea08100619f91b6

Modified Files
--------------
contrib/uuid-ossp/uuid-ossp.c | 4 ++++
1 file changed, 4 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2016-12-18 23:15:47 pgsql: MSVC: Position MSBFLAGS after flags it might override.
Previous Message Tom Lane 2016-12-17 20:29:05 pgsql: Fix FK-based join selectivity estimation for semi/antijoins.