pgsql: Fix unsafe assumption that struct timeval.tv_sec is a "long".

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix unsafe assumption that struct timeval.tv_sec is a "long".
Date: 2016-12-07 00:52:53
Message-ID: E1cEQTd-0008De-CD@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix unsafe assumption that struct timeval.tv_sec is a "long".

It typically is a "long", but it seems possible that on some platforms
it wouldn't be. In any case, this silences a compiler warning on
OpenBSD (cf buildfarm member curculio).

While at it, use snprintf not sprintf. This format string couldn't
possibly overrun the supplied buffer, but that doesn't seem like
a good reason not to use the safer style.

Oversight in commit f828654e1. Back-patch to 9.6 where that came in.

Branch
------
REL9_6_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/81f3c20a65e683ee235a5d3aa6146db84eb75ebf

Modified Files
--------------
src/backend/utils/error/elog.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2016-12-07 04:02:44 pgsql: Silence compiler warnings
Previous Message Tom Lane 2016-12-07 00:34:38 pgsql: Put AC_MSG_RESULT() call in the right place.