| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Fix gin_leafpage_items(). |
| Date: | 2016-11-04 16:12:16 |
| Message-ID: | E1c2h6G-0002KM-GG@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix gin_leafpage_items().
On closer inspection, commit 84ad68d64 broke gin_leafpage_items(),
because the aligned copy of the page got palloc'd in a short-lived
context whereas it needs to be in the SRF's multi_call_memory_ctx.
This was not exposed by the regression test, because the regression
test doesn't actually exercise the function in a meaningful way.
Fix the code bug, and extend the test in what I hope is a portable
fashion.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/367b99bbb13a14bd96bba6f73c231b2056ba9592
Modified Files
--------------
contrib/pageinspect/expected/gin.out | 11 +++++++++--
contrib/pageinspect/ginfuncs.c | 6 +++---
contrib/pageinspect/sql/gin.sql | 9 +++++++--
3 files changed, 19 insertions(+), 7 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-04 16:37:39 | pgsql: Back-patch portability fixes for contrib/pageinspect/ginfuncs.c. |
| Previous Message | Kevin Grittner | 2016-11-04 16:03:37 | pgsql: Improve tab completion for CREATE TRIGGER. |