pgsql: Make regression tests less dependent on hash table order.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Make regression tests less dependent on hash table order.
Date: 2016-10-10 20:45:35
Message-ID: E1bthS3-0006u7-FO@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make regression tests less dependent on hash table order.

Upcoming changes to the hash table code used, among others, for grouping
and set operations will change the output order for a few queries. To
make it less likely that actual bugs are hidden between regression test
ordering changes, and to make the tests robust against platform
dependant ordering, add ORDER BYs guaranteeing the output order.

As it's possible that some of the changes expose platform dependant
ordering, push this earlier, to let the buildfarm shake out potentially
unstable results.

Discussion: <20160727004333(dot)r3e2k2y6fvk2ntup(at)alap3(dot)anarazel(dot)de>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/0137caf273f4297c4d36df3a542d7c0c853e75be

Modified Files
--------------
src/test/regress/expected/matview.out | 6 +-
src/test/regress/expected/psql.out | 2 +-
src/test/regress/expected/tsrf.out | 8 +--
src/test/regress/expected/union.out | 129 ++++++++++++++++++----------------
src/test/regress/expected/with.out | 8 +--
src/test/regress/sql/matview.sql | 4 +-
src/test/regress/sql/psql.sql | 2 +-
src/test/regress/sql/tsrf.sql | 2 +-
src/test/regress/sql/union.sql | 63 +++++++++--------
src/test/regress/sql/with.sql | 8 +--
10 files changed, 123 insertions(+), 109 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-10-10 20:59:42 pgsql: Update user docs for switch to POSIX semaphores.
Previous Message Tom Lane 2016-10-10 14:36:23 pgsql: In PQsendQueryStart(), avoid leaking any left-over async result.