pgsql: libpqwalreceiver needs to link with libintl when using --enable-

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: libpqwalreceiver needs to link with libintl when using --enable-
Date: 2016-10-08 01:12:43
Message-ID: E1bsgBv-0002lO-SU@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

libpqwalreceiver needs to link with libintl when using --enable-nls.

The need for this was previously obscured even on picky platforms
by the hack we used to support direct cross-module references in
the transforms contrib modules. Now that that hack is gone, the
undefined symbol is exposed, as reported by Robert Haas.

Back-patch to 9.5 where we started to use -Wl,-undefined,dynamic_lookup.
I'm a bit surprised that the older branches don't seem to contain
any gettext references in this module, but since they don't fail
at build time, they must not. (We might be able to get away with
leaving this alone in 9.5/9.6, but I think it's cleaner if the
reference gets resolved at link time.)

Report: <CA+TgmoaHJKU5kcWZcYduATYVT7Mnx+8jUnycaYYL7OtCwCigug(at)mail(dot)gmail(dot)com>

Branch
------
REL9_6_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f812b20ba57cd753a5290967db3496790a2dff0f

Modified Files
--------------
src/backend/replication/libpqwalreceiver/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-10-08 22:43:25 pgsql: Remove user_relns() SRF from regression tests.
Previous Message Andres Freund 2016-10-08 00:07:25 pgsql: Fix fallback implementation of pg_atomic_write_u32().