From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix misplacement of submake-generated-headers prerequisites. |
Date: | 2016-10-01 17:35:33 |
Message-ID: | E1bqOCD-0002DN-73@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix misplacement of submake-generated-headers prerequisites.
The sequence "configure; cd src/pl/plpython; make -j" failed due to
trying to compile plpython's .o files before the generated headers
finished building. (This is an important real-world case, since it's
the typical second step when building both plpython2 and plpython3.)
This happens because the submake-generated-headers target is not
placed in a way to make it a prerequisite to compiling the .o files.
Fix that.
Checking other uses of submake-generated-headers, I noted that the one
attached to pg_regress was similarly misplaced; but it's actually not
needed at all for pg_regress.o, rather regress.o, so move it to be a
prerequisite of that.
Back-patch to 9.6 where submake-generated-headers was introduced
(by commit 548af97fc). It's not immediately clear to me why the
previous coding didn't have the same issue; but since we've not
had field reports of plpython make failing, leave it alone in the
older branches.
Pavel Raiskup and Tom Lane
Discussion: <1925924(dot)izSMJEZO3x(at)unused-4-107(dot)brq(dot)redhat(dot)com>
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/7107d58ec5a3c45967e77525809612a5f89b97f3
Modified Files
--------------
src/pl/plpython/Makefile | 4 +++-
src/test/regress/GNUmakefile | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-10-01 17:45:33 | pgsql: Fix misstatement in comment in Makefile.shlib. |
Previous Message | Peter Eisentraut | 2016-10-01 01:32:48 | pgsql: Set log_line_prefix and application name in test drivers |