From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Make struct ParallelSlot private within pg_dump/parallel.c. |
Date: | 2016-09-27 18:29:22 |
Message-ID: | E1box86-00030w-UF@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Make struct ParallelSlot private within pg_dump/parallel.c.
The only field of this struct that other files have any need to touch
is the pointer to the TocEntry a worker is working on. (Well,
pg_backup_archiver.c is actually looking at workerStatus too, but that
can be finessed by specifying that the TocEntry pointer is NULL for a
non-busy worker.)
Hence, move out the TocEntry pointers to a separate array within
struct ParallelState, and then we can make struct ParallelSlot private.
I noted the possibility of this previously, but hadn't got round to
actually doing it.
Discussion: <1188(dot)1464544443(at)sss(dot)pgh(dot)pa(dot)us>
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/0109ab27609c0d58c1eddc6b799077d0968083de
Modified Files
--------------
src/bin/pg_dump/parallel.c | 62 +++++++++++++++++++++++++++++++-----
src/bin/pg_dump/parallel.h | 45 +++-----------------------
src/bin/pg_dump/pg_backup_archiver.c | 12 +++----
3 files changed, 65 insertions(+), 54 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-09-27 22:43:54 | pgsql: Disallow pushing volatile quals past set-returning functions. |
Previous Message | Tom Lane | 2016-09-27 17:56:11 | pgsql: Rationalize parallel dump/restore's handling of worker cmd/statu |