pgsql: Fix and simplify MSVC build's handling of xml/xslt/uuid dependen

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix and simplify MSVC build's handling of xml/xslt/uuid dependen
Date: 2016-09-11 16:47:02
Message-ID: E1bj7uI-0005Xz-K1@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix and simplify MSVC build's handling of xml/xslt/uuid dependencies.

Solution.pm mistakenly believed that the xml option requires the xslt
option, when actually the dependency is the other way around; and it
believed that libxml requires libiconv, which is not necessarily so,
so we shouldn't enforce it here. Fix the option cross-checking logic.

Also, since AddProject already takes care of adding libxml and libxslt
include and library dependencies to every project, there's no need
for the custom code that did that in mkvcbuild. While at it, let's
handle the similar dependencies for uuid in a similar fashion.

Given the lack of field complaints about these overly strict build
dependency requirements, there seems no need for a back-patch.

Michael Paquier

Discussion: <CAB7nPqR0+gpu3mRQvFjf-V-bMxmiSJ6NpTg9_WzVDL+a31cV2g(at)mail(dot)gmail(dot)com>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/28e5e5648cc3666537c393b2636c4aa34fdb22c1

Modified Files
--------------
src/tools/msvc/Mkvcbuild.pm | 22 ++--------------------
src/tools/msvc/Solution.pm | 12 +++++++-----
2 files changed, 9 insertions(+), 25 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-09-11 18:15:14 pgsql: Allow CREATE EXTENSION to follow extension update paths.
Previous Message Heikki Linnakangas 2016-09-11 13:28:01 pgsql: Implement binary heap replace-top operation in a smarter way.